Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vite watchdog #12230

Merged
merged 2 commits into from Nov 2, 2021
Merged

feat: add vite watchdog #12230

merged 2 commits into from Nov 2, 2021

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Nov 2, 2021

Description

Add watchdog to stop vite
when java handler exits or crashes.

Fixes #12060

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Add watchdog to stop vite
when java handler exits or crashes.

Fixes #12060
@caalador caalador added this to In progress in Frontend build optimization via automation Nov 2, 2021
@caalador caalador added the vite Tickets related to vite support label Nov 2, 2021
flow-server/src/main/resources/vite.generated.ts Outdated Show resolved Hide resolved
flow-server/src/main/resources/vite.generated.ts Outdated Show resolved Hide resolved
flow-server/src/main/resources/vite.generated.ts Outdated Show resolved Hide resolved
flow-server/src/main/resources/vite.generated.ts Outdated Show resolved Hide resolved
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 7 issues

  1. MAJOR AbstractDevServerRunner.java#L113: Make "devServerStartFuture" transient or serializable. rule
  2. MAJOR AbstractDevServerRunner.java#L190: Invoke method(s) only conditionally. rule
  3. MAJOR AbstractDevServerRunner.java#L381: Either re-interrupt this method or rethrow the "InterruptedException". rule
  4. MAJOR AbstractDevServerRunner.java#L602: Null passed for non-null parameter of java.util.concurrent.CompletableFuture.getNow(Object) in com.vaadin.base.devserver.AbstractDevServerRunner.handleRequest(VaadinSession, VaadinRequest, VaadinResponse) rule
  5. MAJOR AbstractDevServerRunner.java#L663: Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. rule
  6. MAJOR WebpackHandler.java#L216: Invoke method(s) only conditionally. rule
  7. MINOR AbstractDevServerRunner.java#L633: Replace this if-then-else statement by a single return statement. rule

@Artur- Artur- enabled auto-merge (squash) November 2, 2021 11:01
@Artur- Artur- merged commit e68e335 into master Nov 2, 2021
Frontend build optimization automation moved this from In progress to Done Nov 2, 2021
@Artur- Artur- deleted the issues/12060-vite-watchdog branch November 2, 2021 11:04
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Vite] Watchdog
3 participants