refactor!: Remove StaticFileHandler.isStaticResourceRequest

[Artur-]

This simplifies static file handling so the same logic is not duplicate in two places. It also makes it possible to always query the dev server for files instead of knowing upfront what the dev server can serve.

The method is removed instead of retained as there are two ways it could have been used:

1. Called to check if a given request is a static resource request
2. Overridden in a custom StaticFileHandler

To keep the method we would need to do the following for the cases:

1. Make isStaticResourceRequest return serveStaticResource() != null
2. Make serveStaticResource() call isStaticResourceRequest() as the first thing

We cannot do both so it is safer to remove the method to force code to be updated

[pleku]

Even if it is unlikely that anyone is using this API, should it be marked as refactor!: so that it gets mentioned in the release notes ?

[knoobie]

Isn't the vaadin website using this API? Looking at the PR / feature request that introduced this feature? #4914

It's possible that some users have used this API for the exact same thing.

[Artur-]

It is still possible to override it in the same way. Only it should be simpler because there is one method and not two

[vaadin-bot]

SonarQube analysis reported 14 issues

• 7 major
• 7 minor

Top 10 issues

1. StaticFileServer.java#L127: Replace this with a call to the "toFile().isDirectory()" method
2. StaticFileServer.java#L137: Replace this with a call to the "toFile().isDirectory()" method
3. AbstractDevServerRunner.java#L114: Make "devServerStartFuture" transient or serializable.
4. AbstractDevServerRunner.java#L191: Invoke method(s) only conditionally.
5. AbstractDevServerRunner.java#L382: Either re-interrupt this method or rethrow the "InterruptedException".
6. AbstractDevServerRunner.java#L612: Null passed for non-null parameter of java.util.concurrent.CompletableFuture.getNow(Object) in com.vaadin.base.devserver.AbstractDevServerRunner.handleRequest(VaadinSession, VaadinRequest, VaadinResponse)
7. AbstractDevServerRunner.java#L673: Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed.
8. StaticFileServer.java#L178: Move the "file" string literal on the left side of this string comparison.
9. VaadinServlet.java#L196: Remove the declaration of thrown exception 'javax.servlet.ServletException', as it cannot be thrown from method's body.
10. VaadinServlet.java#L331: Replace this if-then-else statement by a single return statement.

[vaadin-bot]

This ticket/PR has been released with platform 22.0.0.beta1 and is also targeting the upcoming stable 22.0.0 version.