Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Auto-update Node for alternative directory #12270

Merged
merged 1 commit into from Nov 4, 2021
Merged

Conversation

mshabarov
Copy link
Contributor

Description

Auto-updates Node version when the Node is forced to be located in only alternative directory.

Fixes #12264

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 4 issues

  1. MAJOR FrontendTools.java#L161: Define and throw a dedicated exception instead of using a generic one. rule
  2. MAJOR FrontendTools.java#L392: Constructor has 8 parameters, which is greater than 7 authorized. rule
  3. MAJOR FrontendTools.java#L690: A "NullPointerException" could be thrown; "output" is nullable here. rule
  4. MINOR FrontendTools.java#L682: Remove the declaration of thrown exception 'java.lang.IllegalStateException' which is a runtime exception. rule

@caalador caalador merged commit 6dcfaa7 into master Nov 4, 2021
@caalador caalador deleted the fix/node-update branch November 4, 2021 10:28
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJS auto-update doesn't work if alternative directory is forced
3 participants