fix: Make URLUtil.encodeURI behave like encodeURI in JavaScript and add encodeURIComponent #12291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd encodeURIComponent
Artur-
force-pushed
the
urlutil-encodeuri
branch
from
05ba370
to
2cced68
Compare
|
SonarQube analysis reported 2 issues
|
Artur-
changed the title
caalador
reviewed
Nov 8, 2021
| URI uri = new URI(UrlUtil.encodeURI(strippedPath)); | ||
| // : is completely valid in a path but URI will think that defines a | ||
| // protocol so skip it for the check | ||
| URI uri = new URI(UrlUtil.encodeURI(strippedPath).replace(":", "")); | ||
| if (uri.isAbsolute()) { |
There was a problem hiding this comment.
Is the initial check un-necessary as we can never have a uri with a scheme at this point?
There was a problem hiding this comment.
It would seem so if we first remove : and then check for :
Let's fix in a separate PR
caalador
approved these changes
Nov 8, 2021
|
This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version. |
joheriks
pushed a commit
that referenced
this pull request
Feb 3, 2022
…dd encodeURIComponent (#12291)
joheriks
pushed a commit
that referenced
this pull request
Feb 3, 2022
…dd encodeURIComponent (#12291)
joheriks
pushed a commit
that referenced
this pull request
Feb 4, 2022
…dd encodeURIComponent (#12291)
joheriks
pushed a commit
that referenced
this pull request
Feb 4, 2022
…dd encodeURIComponent (#12291)
|
This ticket/PR has been released with platform 14.8.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.