Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mention vaadin.whitelisted-packages as a possible cause of missing template file #12310

Merged
merged 2 commits into from Nov 9, 2021

Conversation

tarekoraby
Copy link
Contributor

Fixes #10120

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 2 issues

  1. MAJOR LitTemplateParserImpl.java#L98: Reduce the total number of break and continue statements in this loop to use at most one. rule
  2. MAJOR NpmTemplateParser.java#L104: Reduce the total number of break and continue statements in this loop to use at most one. rule

@tarekoraby tarekoraby merged commit 5a40c0e into master Nov 9, 2021
@tarekoraby tarekoraby deleted the whitelisted-packages-error branch November 9, 2021 10:12
Copy link
Contributor

@Haprog Haprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a Spring Boot project, please ensure that the template's groupId is added to the vaadin.whitelisted-packages property.

Is this the case only if you're using vaadin.whitelisted-packages? If so the message should probably be adjusted to include that. Now it seems like you always need to add to vaadin.whitelisted-packages (even if you didn't use it before) in a Spring Boot project.

Just realized this after approving.

@tarekoraby
Copy link
Contributor Author

Well, our starters from Vaadin starter come with the vaadin.whitelisted-packages property already preset. So the developer might not even know that such a property is activated on their project.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when TemplateData is missing due to vaadin.whitelisted-packages
3 participants