Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Log dev server output using standard logger #12321

Merged
merged 4 commits into from Nov 10, 2021
Merged

fix: Log dev server output using standard logger #12321

merged 4 commits into from Nov 10, 2021

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Nov 9, 2021

Fixes #12281

@Artur- Artur- added the vite Tickets related to vite support label Nov 9, 2021
@Artur- Artur- added this to In progress in Frontend build optimization via automation Nov 9, 2021
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 8 issues

  1. MAJOR AbstractDevServerRunner.java#L112: Make "devServerStartFuture" transient or serializable. rule
  2. MAJOR AbstractDevServerRunner.java#L189: Invoke method(s) only conditionally. rule
  3. MAJOR AbstractDevServerRunner.java#L380: Either re-interrupt this method or rethrow the "InterruptedException". rule
  4. MAJOR AbstractDevServerRunner.java#L606: Null passed for non-null parameter of java.util.concurrent.CompletableFuture.getNow(Object) in com.vaadin.base.devserver.AbstractDevServerRunner.handleRequest(VaadinSession, VaadinRequest, VaadinResponse) rule
  5. MAJOR AbstractDevServerRunner.java#L653: Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. rule
  6. MINOR AbstractDevServerRunner.java#L678: Move the "" string literal on the left side of this string comparison. rule
  7. MINOR AbstractDevServerRunner.java#L678: Move the "/" string literal on the left side of this string comparison. rule
  8. MINOR DevServerOutputTracker.java#L200: Move this method into "Finder". rule

@Artur- Artur- enabled auto-merge (squash) November 10, 2021 08:52
@Artur- Artur- merged commit 36307ca into master Nov 10, 2021
@Artur- Artur- deleted the dev-server-log-to-logger branch November 10, 2021 11:27
Frontend build optimization automation moved this from In progress to Done Nov 10, 2021
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

@joheriks joheriks Awaiting requested review from joheriks

Assignees
No one assigned
Labels
prerelease version for platform 22.0.0 Released with Platform 22.0.0.beta2 vite Tickets related to vite support +0.0.1
Projects
Frontend build optimization
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send dev server output to normal log output
3 participants
@Artur- @vaadin-bot @caalador