Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New mechanism for usage data collection (#12381) (CP: 9.0) #12550

Merged
merged 1 commit into from
Dec 9, 2021
Merged

New mechanism for usage data collection (#12381) (CP: 9.0) #12550

merged 1 commit into from
Dec 9, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@samie @pleku
@Artur- @vaadin-bot
feat: add new usage data collection for dev-mode (#12381)
45b7acd 
Collects usage statistics once a day in development mode.
Can be opt out with `devmode.usageStatistics.enabled` configuration parameter.

Co-authored-by: Pekka Hyvönen <pekka@vaadin.com>
Co-authored-by: Artur Signell <artur@vaadin.com>
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Unit Test Results

   719 files     719 suites   18m 49s ⏱️
5 640 tests 5 590 ✔️ 50 💤 0 ❌
5 655 runs  5 605 ✔️ 50 💤 0 ❌

Results for commit 45b7acd.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 17 issues

  • MAJOR 9 major
  • MINOR 6 minor
  • INFO 2 info

Top 10 issues

  1. MAJOR AbstractDevServerRunner.java#L119: Make "devServerStartFuture" transient or serializable. rule
  2. MAJOR AbstractDevServerRunner.java#L196: Invoke method(s) only conditionally. rule
  3. MAJOR AbstractDevServerRunner.java#L307: Remove this unused method parameter "nodeVersion". rule
  4. MAJOR AbstractDevServerRunner.java#L414: Either re-interrupt this method or rethrow the "InterruptedException". rule
  5. MAJOR AbstractDevServerRunner.java#L641: Null passed for non-null parameter of java.util.concurrent.CompletableFuture.getNow(Object) in com.vaadin.base.devserver.AbstractDevServerRunner.handleRequest(VaadinSession, VaadinRequest, VaadinResponse) rule
  6. MAJOR AbstractDevServerRunner.java#L688: Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. rule
  7. MAJOR DevModeInitializer.java#L422: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule
  8. MAJOR StatisticsSender.java#L224: Reduce this lambda expression number of lines from 28 to at most 20. rule
  9. MAJOR StatisticsStorage.java#L171: Exceptional return value of java.io.File.mkdirs() ignored in com.vaadin.base.devserver.stats.StatisticsStorage.internalWrite(ObjectNode) rule
  10. MINOR PropertyDeploymentConfiguration.java#L219: Remove this method to simply inherit it. rule

@manolo manolo merged commit 161382b into 9.0 Dec 9, 2021
@manolo manolo deleted the cherry-pick-12381-to-9.0-1639055715520 branch December 9, 2021 14:30
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 22.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manolo manolo manolo approved these changes

Assignees
No one assigned
Labels
Released with Platform 22.0.2 +1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaadin-bot @manolo @samie