Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix edge user agent #13446

Merged
merged 1 commit into from Apr 7, 2022
Merged

fix: Fix edge user agent #13446

merged 1 commit into from Apr 7, 2022

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Apr 7, 2022

Fix determining edge from userAgent used in newer versions.

Fixes #13445

Fix determining edge from userAgent.

Fixes #13445
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Unit Test Results

   955 files  ±0     955 suites  ±0   52m 55s ⏱️ + 1m 38s
6 202 tests +4  6 153 ✔️ +4  49 💤 ±0  0 ±0 
6 416 runs  +2  6 361 ✔️ +2  55 💤 ±0  0 ±0 

Results for commit f2816ff. ± Comparison against base commit 6132707.

@Artur- Artur- merged commit 4305f67 into master Apr 7, 2022
@Artur- Artur- deleted the issues/13445-fix-edge-check branch April 7, 2022 13:09
vaadin-bot pushed a commit that referenced this pull request Apr 7, 2022
@vaadin-bot
Copy link
Collaborator

Hi @caalador and @Artur-, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4305f67
error: could not apply 4305f67... fix: Fix determining edge from userAgent (#13446)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @caalador and @Artur-, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4305f67
error: could not apply 4305f67... fix: Fix determining edge from userAgent (#13446)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

caalador added a commit that referenced this pull request Apr 8, 2022
mshabarov pushed a commit that referenced this pull request Apr 8, 2022
caalador added a commit that referenced this pull request Apr 8, 2022
vaadin-bot added a commit that referenced this pull request Apr 8, 2022
Fixes #13445

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
mcollovati pushed a commit that referenced this pull request Apr 8, 2022
Fixes #13445

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
ZheSun88 pushed a commit that referenced this pull request Apr 10, 2022
Fixes #13445

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Co-authored-by: Artur Signell <artur@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.0.7.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.rc2 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebBrowser.isEdge() is false for Edge
4 participants