Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support @NonNullApi to define @Nonnull for all methods in a package #13615

Merged
merged 6 commits into from May 23, 2022

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Apr 25, 2022

@NonNullApi can be used as a package level annotation, on package-info.java, to define that all method return types and parameter types should be considered @Nonnull. Individual parameter or return types can be overridden to allow null using@Nullable.

For vaadin/hilla#107

@Artur- Artur- changed the title Support @NonNullApi feat: Support @NonNullApi to define @Nonnull for all methods in a package Apr 25, 2022
@github-actions
Copy link

github-actions bot commented Apr 25, 2022

Unit Test Results

   969 files  +  42     969 suites  +42   48m 30s ⏱️ + 1m 21s
6 286 tests +276  6 238 ✔️ +273  48 💤 +3  0 ±0 
6 511 runs  +276  6 457 ✔️ +273  54 💤 +3  0 ±0 

Results for commit 2640875. ± Comparison against base commit b4de375.

♻️ This comment has been updated with latest results.

…tGenerator.java

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Apr 27, 2022
@Artur- Artur- requested a review from platosha April 29, 2022 10:10
@caalador caalador added the hilla Issues related to Hilla label May 2, 2022
@vaadin-bot vaadin-bot added +0.1.0 and removed +1.0.0 labels May 11, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels May 21, 2022
@Artur- Artur- merged commit bbbadb7 into master May 23, 2022
@Artur- Artur- deleted the feature/nonnullapi branch May 23, 2022 07:05
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants