feat: enable components to notify binder when validation state changes #13940

taefi · 2022-06-09T14:25:45Z

Description

Adds the needed API to notify Binder about validation status changes that happen in field components.

Fixes #8242
Related to vaadin/flow-components#1158

Type of change

Bugfix
Feature

Checklist

I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

…s changes

github-actions · 2022-06-09T14:42:31Z

Unit Test Results

  974 files +  1   974 suites +1 48m 57s ⏱️ + 2m 56s
6 320 tests +  8 6 272 ✔️ +8 48 💤 ±0 0 ❌ ±0
6 548 runs +12 6 494 ✔️ +9 54 💤 +3 0 ❌ ±0

Results for commit e60de2a. ± Comparison against base commit 7024ad3.

♻️ This comment has been updated with latest results.

…dation

When the number of tests grows the timeout also should be increased.

.github/workflows/validation.yml

flow-data/src/main/java/com/vaadin/flow/data/binder/ValidationStatusChangeEvent.java

flow-data/src/main/java/com/vaadin/flow/data/binder/ValidationStatusChangeListener.java

…dation

flow-data/src/main/java/com/vaadin/flow/data/binder/HasValidator.java

#13940) * feat: enable components to notify binder about their validation status changes Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>

#13940) (#13994) * feat: enable components to notify binder about their validation status changes Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com> Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>

#13940) (CP: 23.1) (#13993) Adds the needed API to notify Binder about validation status changes that happen in field components. Fixes #8242 Related to vaadin/flow-components#1158

#13940) (CP: 9.0) (#13996) * feat: enable components to notify binder when validation state changes (#13940) Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>

#13940) (CP: 2.8) (#13995) * feat: enable components to notify binder when validation state changes (#13940) Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>

#13940) (CP: 2.7) (#13997) * feat: enable components to notify binder when validation state changes (#13940) Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>

knoobie · 2022-07-05T06:28:50Z

@mshabarov I would like to work on a solution to deactivate this feature; I was wondering if you guys would prefer it on Binder-level or Binding-level.

This could later be enhanced from private boolean enableFieldValidation = false / true as default to private boolean enableFieldValidation = FeatureFlags.get(BINDER_FIELD_VALIDATION); if you guys wanna put it behind a feature flag and swap the default value later on.

…on binder Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment)

…on binder (#14198) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment) Co-authored-by: Knoobie <Knoobie@gmx.de>

…on binder (#14197) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment) Co-authored-by: Knoobie <Knoobie@gmx.de>

…on binder (#14158) (CP: 9.0) (#14199) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment) Co-authored-by: Knoobie <Knoobie@gmx.de> Co-authored-by: Marco Collovati <marco@vaadin.com>

…on binder Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment) (cherry picked from commit 420498c)

…on binder (#14205) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and vaadin/flow-components#3406 (comment) (cherry picked from commit 420498c) Co-authored-by: Knoobie <knoobie@gmx.de>

…on binder (#14205) (#14208) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and vaadin/flow-components#3406 (comment) (cherry picked from commit 420498c) Co-authored-by: Knoobie <knoobie@gmx.de> Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>

vaadin-bot · 2022-09-07T10:23:44Z

This ticket/PR has been released with Vaadin 23.2.0.

feat: enable components to notify binder about their validation statu…

5fae336

…s changes

vaadin-bot added the +1.0.0 label Jun 9, 2022

TatuLund marked this pull request as ready for review June 9, 2022 17:04

Merge branch 'master' into taefi/feat/validate-binder-after-comp-vali…

c0848ac

…dation

taefi added +0.1.0 and removed +1.0.0 labels Jun 10, 2022

mshabarov self-requested a review June 13, 2022 05:57

taefi added 3 commits June 13, 2022 11:05

Merge branch 'master' into taefi/feat/validate-binder-after-comp-vali…

94ac3b7

…dation

add tests and fix javadocs

0ee5d8e

Merge branch 'master' into taefi/feat/validate-binder-after-comp-vali…

078e4af

…dation

vaadin-bot added +1.0.0 and removed +0.1.0 labels Jun 13, 2022

taefi added 2 commits June 14, 2022 09:47

fix javadocs

d210303

update timeout to 20 minutes

61abbd5

When the number of tests grows the timeout also should be increased.

mshabarov requested changes Jun 15, 2022

View reviewed changes

.github/workflows/validation.yml Outdated Show resolved Hide resolved

flow-data/src/main/java/com/vaadin/flow/data/binder/ValidationStatusChangeEvent.java Show resolved Hide resolved

flow-data/src/main/java/com/vaadin/flow/data/binder/ValidationStatusChangeListener.java Show resolved Hide resolved

chore: revert timeout to 15 minutes

b70c057

yuriy-fix mentioned this pull request Jun 15, 2022

Input components chained validation logic vaadin/platform#3066

Closed

14 tasks

taefi added 3 commits June 15, 2022 20:54

Merge branch 'master' into taefi/feat/validate-binder-after-comp-vali…

69423f8

…dation

apply review suggestions

21f7239

Merge branch 'master' into taefi/feat/validate-binder-after-comp-vali…

f388de6

…dation

sonatype-lift bot reviewed Jun 15, 2022

View reviewed changes

flow-data/src/main/java/com/vaadin/flow/data/binder/HasValidator.java Outdated Show resolved Hide resolved

apply review suggestions

4f4b798

taefi requested a review from mshabarov June 15, 2022 18:33

taefi added 4 commits June 15, 2022 21:43

apply review suggestions

361dd85

fix javadoc

d060223

fix javadoc

e73d55a

fix javadoc

be9587d

sonatype-lift bot reviewed Jun 15, 2022

View reviewed changes

flow-data/src/main/java/com/vaadin/flow/data/binder/HasValidator.java Outdated Show resolved Hide resolved

mshabarov reviewed Jun 16, 2022

View reviewed changes

flow-data/src/main/java/com/vaadin/flow/data/binder/HasValidator.java Outdated Show resolved Hide resolved

vaadin-bot added the cherry-picked-23.0 label Jun 16, 2022

vaadin-bot added the cherry-picked-2.8 label Jun 16, 2022

vaadin-bot added the cherry-picked-9.0 label Jun 16, 2022

vaadin-bot added the cherry-picked-2.7 label Jun 16, 2022

taefi mentioned this pull request Jun 30, 2022

feat: remove validation status change listener upon unbind #14111

Merged

9 tasks

knoobie mentioned this pull request Jul 11, 2022

feat: allow disabling validation status change listener registration on binder #14158

Merged

9 tasks

taefi mentioned this pull request Jul 22, 2022

feat: allow disabling validation status change listener registration on binder (CP: 2.7) #14205

Merged

vaadin-bot added the Released with Vaadin 23.2.0 label Sep 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable components to notify binder when validation state changes #13940

feat: enable components to notify binder when validation state changes #13940

taefi commented Jun 9, 2022 •

edited

github-actions bot commented Jun 9, 2022 •

edited

knoobie commented Jul 5, 2022 •

edited

vaadin-bot commented Sep 7, 2022

feat: enable components to notify binder when validation state changes #13940

feat: enable components to notify binder when validation state changes #13940

Conversation

taefi commented Jun 9, 2022 • edited

Description

Type of change

Checklist

Additional for Feature type of change

github-actions bot commented Jun 9, 2022 • edited

Unit Test Results

knoobie commented Jul 5, 2022 • edited

vaadin-bot commented Sep 7, 2022

taefi commented Jun 9, 2022 •

edited

Additional for `Feature` type of change

github-actions bot commented Jun 9, 2022 •

edited

knoobie commented Jul 5, 2022 •

edited