fix: Do not rely on web components calling the license checker #14028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Jun 22, 2022
vursen
reviewed
Jun 22, 2022
flow-server/src/main/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandler.java
Outdated
Show resolved
Hide resolved
vursen
reviewed
Jun 23, 2022
| if (failedLicenseCheck) { | ||
| // Has been checked and the check failed | ||
| const { connectedCallback } = constructor.prototype; | ||
| constructor.prototype.connectedCallback = function () { |
There was a problem hiding this comment.
The connectedCallback should be also overridden in the case the license is not checked yet. Otherwise, the license fallback will never be shown if the license check fails while the component is still not in the DOM.
There was a problem hiding this comment.
Fixed so it is always overwritten
Use the same key for productMissingLicense and productCheckOk
Artur-
force-pushed
the
trigger-license-check
branch
from
f5882fe
to
81eda09
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Jun 23, 2022
|
This ticket/PR has been released with Vaadin 23.2.0. |
mshabarov
pushed a commit
that referenced
this pull request
Oct 10, 2022
(cherry picked from commit 60a8728)
mshabarov
pushed a commit
that referenced
this pull request
Oct 18, 2022
(cherry picked from commit 60a8728)
mshabarov
pushed a commit
that referenced
this pull request
Oct 19, 2022
(cherry picked from commit 60a8728)
caalador
pushed a commit
that referenced
this pull request
Oct 20, 2022
(cherry picked from commit 60a8728)
|
This ticket/PR has been released with Vaadin 14.9.0.beta1 and is also targeting the upcoming stable 14.9.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.