Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always generate themes in frontend 'generated' directory subfolder (#14144) (CP: 23.0) #14156

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

…er (#14144)

Forces generated themes files to be stored in 'generated' folder under
frontend directory, instead of using the 'generatedTsFolder' setting.
Also fixes relative paths assuming frontend directory to be './frontend',
and maven and gradle plugins to clean the 'frontendDirectory/generated' folder.

Fixes #12880
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

Unit Test Results

   954 files     954 suites   50m 34s ⏱️
6 241 tests 6 192 ✔️ 49 💤 0
6 466 runs  6 411 ✔️ 55 💤 0

Results for commit e3b900e.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati mcollovati merged commit 998e208 into 23.0 Jul 11, 2022
@mcollovati mcollovati deleted the cherry-pick-14144-to-23.0-1657386074855 branch July 11, 2022 11:18
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 23.0.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants