Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provides collection based methods for HasComponents #14202

Conversation

MarcinVaadin
Copy link
Member

@MarcinVaadin MarcinVaadin commented Jul 22, 2022

Description

Added Collection based add / remove methods for com.vaadin.flow.component.HasComponents

Fixes #13598

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended. feature already covered with tests
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@MarcinVaadin MarcinVaadin linked an issue Jul 22, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jul 22, 2022

Unit Test Results

   904 files  +107     904 suites  +107   59m 19s ⏱️ + 13m 15s
5 894 tests +  64  5 851 ✔️ +  92  43 💤 ±0  0  - 7 
6 115 runs  +215  6 066 ✔️ +238  49 💤 +5  0  - 7 

Results for commit 6bbfddb. ± Comparison against base commit 4e62c04.

♻️ This comment has been updated with latest results.

@mshabarov mshabarov self-requested a review July 25, 2022 11:24
@mshabarov mshabarov added +0.1.0 and removed +1.0.0 labels Jul 28, 2022
@mshabarov mshabarov enabled auto-merge (squash) July 29, 2022 09:13
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.1.0 labels Jul 29, 2022
@mshabarov mshabarov merged commit e44a7eb into master Jul 29, 2022
@mshabarov mshabarov deleted the issues/13598-provide-collection-based-methods-for-hascomponents branch July 29, 2022 09:58
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide collection based methods for HasComponents
3 participants