feat: provides collection based append/remove methods for Node #14204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
taefi
reviewed
Jul 22, 2022
| } | ||
|
|
||
| /** | ||
| * Removes the given child element(s). |
There was a problem hiding this comment.
Not exactly sure, but I guess now that these new APIs are accepting a collection it is fine to just use the plural without parenthesis:
Suggested change
| * Removes the given child element(s). | |
| * Removes the given child elements. |
There was a problem hiding this comment.
Collection may contain only one element, so probably that's fine to say "element(s)"
taefi
approved these changes
Jul 22, 2022
mshabarov
approved these changes
Jul 28, 2022
mshabarov
deleted the
issues/13599-provide-collection-based-appendremove-methods-for-node-2
branch
|
This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Collection based appendChild / appendVirtualChild / insertChild / removeChild / removeVirtualChild methods for
com.vaadin.flow.dom.NodeFixes #13599
Type of change
Checklist
I have added tests to ensure my change is effective and works as intended.already covered with testsAdditional for
Featuretype of change