fix: regenerate theme files if not existing during Vite resolution #14307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may happen that when Vite analyses imports for theme.js file, they are not yet generated of filesystem and this make compilation fail. This change checks for theme.js imports existence, and if not present forces theme generation process
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
approved these changes
Aug 10, 2022
|
This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may happen that when Vite analyses imports for theme.js file,
they are not yet generated of filesystem and this make compilation
fail.
This change checks for theme.js imports existence, and if not present
forces theme generation process
Should fix ThemeSwitchLiveReloadIT flakiness