Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Redirect if refresh token is in push response also #14777

Merged
merged 1 commit into from
Oct 10, 2022
Merged

fix: Redirect if refresh token is in push response also #14777

merged 1 commit into from
Oct 10, 2022

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Oct 7, 2022

Fixes #14753

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Oct 7, 2022 •
edited

Unit Test Results

   955 files  ±0     955 suites  ±0   49m 37s ⏱️ +50s
6 083 tests ±0  6 029 ✔️ ±0  54 💤 ±0  0 ❌ ±0 
6 346 runs   - 1  6 284 ✔️  - 1  62 💤 ±0  0 ❌ ±0 

Results for commit 4e93353. ± Comparison against base commit 61ac6e6.

♻️ This comment has been updated with latest results.

@caalador caalador merged commit 2c5c318 into master Oct 10, 2022
@caalador caalador deleted the feature/pushredirect branch October 10, 2022 04:08
vaadin-bot pushed a commit that referenced this pull request Oct 10, 2022
@Artur- @vaadin-bot
fix: Redirect if refresh token is in push response also (#14777)
5ec7320 
Fixes #14753
vaadin-bot pushed a commit that referenced this pull request Oct 10, 2022
@Artur- @vaadin-bot
fix: Redirect if refresh token is in push response also (#14777)
11134b8 
Fixes #14753
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 2c5c318
error: could not apply 2c5c318... fix: Redirect if refresh token is in push response also (#14777)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot pushed a commit that referenced this pull request Oct 10, 2022
@Artur- @vaadin-bot
fix: Redirect if refresh token is in push response also (#14777)
c55a5ec 
Fixes #14753
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 2c5c318
error: could not apply 2c5c318... fix: Redirect if refresh token is in push response also (#14777)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

caalador pushed a commit that referenced this pull request Oct 10, 2022
@Artur- @caalador
fix: Redirect if refresh token is in push response also (#14777)
ed34b5c 
Fixes #14753
# Conflicts:
#	flow-client/src/main/java/com/vaadin/client/communication/DefaultConnectionStateHandler.java
caalador added a commit that referenced this pull request Oct 10, 2022
@caalador
fix: Redirect if refresh token is in push response also (#14777) (#14786
4f29c11 
)

Fixes #14753
vaadin-bot pushed a commit that referenced this pull request Oct 10, 2022
@caalador @vaadin-bot
fix: Redirect if refresh token is in push response also (#14777) (#14786
560667d 
)

Fixes #14753
caalador pushed a commit that referenced this pull request Oct 11, 2022
@vaadin-bot @Artur-
fix: Redirect if refresh token is in push response also (#14777) (#14780
122a3d1 
)

Fixes #14753

Co-authored-by: Artur <artur@vaadin.com>
caalador pushed a commit that referenced this pull request Oct 11, 2022
@vaadin-bot @Artur-
fix: Redirect if refresh token is in push response also (#14777) (#14781
ad197a1 
)

Fixes #14753

Co-authored-by: Artur <artur@vaadin.com>
caalador pushed a commit that referenced this pull request Oct 11, 2022
@vaadin-bot @Artur-
fix: Redirect if refresh token is in push response also (#14777) (#14782
acd31f5 
)

Fixes #14753

Co-authored-by: Artur <artur@vaadin.com>
caalador added a commit that referenced this pull request Oct 11, 2022
@vaadin-bot @caalador
fix: Redirect if refresh token is in push response also (#14777) (#14786
24aad2e 
) (#14789)

Fixes #14753

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-9.0 cherry-picked-23.1 cherry-picked-23.2 need to pick manually 2.7 need to pick manually 2.8 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Invalid JSON from server" even when Push response contains Vaadin-Refresh
3 participants
@Artur- @vaadin-bot @caalador