New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: defer location and query tracking (#14742) (CP: 23.1) #14791

Merged

caalador merged 1 commit into 23.1 from cherry-pick-14742-to-23.1-1665397782091

Oct 11, 2022

Collaborator

vaadin-bot commented Oct 10, 2022

No description provided.


          fix: defer location and query tracking (#14742)

8d910a0

Track of location and query string after response from server
happens too early when handling server side navigation,
because history.pushState is executed within a setTimeout.
This change defers the tracking to the next event loop cycle
in order to get the correct values.

Fixes #14323

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

vaadin-bot added the +0.0.1 label

github-actions bot commented Oct 10, 2022 •

edited

Unit Test Results

  978 files +1   978 suites +1 1h 1m 44s ⏱️ + 2m 55s
6 346 tests +2 6 297 ✔️ +2 49 💤 ±0 0 ❌ ±0
6 577 runs ±0 6 522 ✔️ ±0 55 💤 ±0 0 ❌ ±0

Results for commit 8d910a0. ± Comparison against base commit a7410c5.

♻️ This comment has been updated with latest results.

caalador approved these changes

View reviewed changes

caalador merged commit 97b7e71 into 23.1

caalador deleted the cherry-pick-14742-to-23.1-1665397782091 branch

October 11, 2022 08:38

Collaborator Author

vaadin-bot commented Oct 24, 2022

This ticket/PR has been released with Vaadin 23.1.13.

vaadin-bot added the Released with Vaadin 23.1.13 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment