fix: synchronize pwa handler on map #14838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronize pwa handler on the requestHandlerMap instead of locking the session. Locking and unlocking session may fire a push event that might make the server client sync faulty. touches #14797
|
Kudos, SonarCloud Quality Gate passed!
|
mcollovati
approved these changes
Oct 17, 2022
caalador
changed the title
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Oct 17, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Synchronize pwa handler on the requestHandlerMap instead of locking the session. Locking and unlocking session may fire a push event that might make the server client sync faulty. touches #14797
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Synchronize pwa handler on the requestHandlerMap instead of locking the session. Locking and unlocking session may fire a push event that might make the server client sync faulty. touches #14797
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Synchronize pwa handler on the requestHandlerMap instead of locking the session. Locking and unlocking session may fire a push event that might make the server client sync faulty. touches #14797
|
Hi @caalador and @caalador, when i performed cherry-pick to this commit to 9.0, i have encountered the following issue. Can you take a look and pick it manually? |
caalador
added a commit
that referenced
this pull request
Oct 17, 2022
Synchronize pwa handler on the requestHandlerMap instead of locking the session. Locking and unlocking session may fire a push event that might make the server client sync faulty. touches #14797
caalador
added a commit
that referenced
this pull request
Oct 17, 2022
Synchronize pwa handler on the requestHandlerMap instead of locking the session. Locking and unlocking session may fire a push event that might make the server client sync faulty. touches #14797 Co-authored-by: caalador <mikael.grankvist@vaadin.com>
caalador
added a commit
that referenced
this pull request
Oct 17, 2022
Synchronize pwa handler on the requestHandlerMap instead of locking the session. Locking and unlocking session may fire a push event that might make the server client sync faulty. touches #14797 Co-authored-by: caalador <mikael.grankvist@vaadin.com>
caalador
added a commit
that referenced
this pull request
Oct 17, 2022
Synchronize pwa handler on the requestHandlerMap instead of locking the session. Locking and unlocking session may fire a push event that might make the server client sync faulty. touches #14797 Co-authored-by: caalador <mikael.grankvist@vaadin.com>
caalador
added a commit
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize pwa handler on the
requestHandlerMap instead of
locking the session.
Locking and unlocking session may
fire a push event that might make the
server client sync faulty.
touches #14797