Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove special Idea case for Mac #15720

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: Remove special Idea case for Mac #15720

merged 1 commit into from
Jan 20, 2023

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jan 19, 2023

If you have multiple versions installed, e.g. community and ultimate, the protocol might open the wrong one

If you have multiple versions installed, e.g. community and ultimate, the protocol might open the wrong one
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Test Results

   940 files  ±0     940 suites  ±0   57m 53s ⏱️ + 4m 48s
5 878 tests ±0  5 843 ✔️ ±0  35 💤 ±0  0 ±0 
6 132 runs  +6  6 090 ✔️ +6  42 💤 ±0  0 ±0 

Results for commit 1945191. ± Comparison against base commit bc5c72c.

Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I cannot try it because I have not a Mac

@Artur-
Copy link
Member Author

Artur- commented Jan 20, 2023

Thank god!

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants