Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward messages asynchronously in Vite websocket proxy #15747

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

mcollovati
Copy link
Collaborator

Description

Prevents deadlocks in Quarkus environments.

Fixes #15744

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Prevents deadlocks in Quarkus environments.

Fixes #15744
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Test Results

   940 files  ±  0     940 suites  ±0   54m 29s ⏱️ +46s
5 887 tests ±  0  5 852 ✔️ ±  0  35 💤 ±0  0 ±0 
6 139 runs  +11  6 097 ✔️ +11  42 💤 ±0  0 ±0 

Results for commit bf6ebe9. ± Comparison against base commit 3951cce.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus vertx issues with Vite dev mode connection
3 participants