Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always set image alt text the same way #15757

Merged
merged 2 commits into from
Jan 26, 2023
Merged

fix: Always set image alt text the same way #15757

merged 2 commits into from
Jan 26, 2023

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jan 25, 2023

Fixes #15756

@Artur- Artur- marked this pull request as ready for review January 25, 2023 13:07
@Artur- Artur- requested a review from caalador January 25, 2023 13:07
@Artur- Artur- enabled auto-merge (squash) January 25, 2023 13:07
@github-actions
Copy link

github-actions bot commented Jan 25, 2023 •
edited

Test Results

   940 files  ±0     940 suites  ±0   54m 21s ⏱️ - 1m 59s
5 887 tests ±0  5 852 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
6 137 runs   - 3  6 095 ✔️  - 3  42 💤 ±0  0 ❌ ±0 

Results for commit 873a32f. ± Comparison against base commit 2c0bc21.

♻️ This comment has been updated with latest results.

caalador
caalador previously approved these changes Jan 26, 2023
View reviewed changes
@caalador
Copy link
Contributor

Some image tests need updated expectations

Error:  setAndResetValues(com.vaadin.flow.component.html.ImageTest)  Time elapsed: 0.008 s  <<< FAILURE!
java.lang.AssertionError: Default value for alt should be an empty Optional expected:<Optional.empty> but was:<Optional[]>

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur- Artur- merged commit c622a15 into master Jan 26, 2023
@Artur- Artur- deleted the img-alt branch January 26, 2023 13:11
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

vaadin-bot pushed a commit that referenced this pull request Oct 2, 2023
@Artur- @vaadin-bot
fix: Always set image alt text the same way (#15757)
3842979 
Fixes #15756
vaadin-bot added a commit that referenced this pull request Oct 2, 2023
@vaadin-bot @Artur-
fix: Always set image alt text the same way (#15757) (#17756)
0fc5502 
Fixes #15756

Co-authored-by: Artur <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.3 prerelease version for Vaadin 24.0.0 Released with Vaadin 24.0.0.alpha10 target/23.3 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image.getAlt() not working if alt text set by constructor
4 participants
@Artur- @caalador @vaadin-bot @mshabarov