Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable skipping dev bundle rebuild #16526

Merged
merged 5 commits into from Apr 11, 2023
Merged

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Apr 4, 2023

Make it possible to skip
checks for devBundle rebuild.

Closes #16037

Make it possible to skip
checks for devBundle rebuild.

Closes #16037
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Test Results

   981 files  ±0     981 suites  ±0   1h 12m 44s ⏱️ + 5m 21s
6 174 tests +1  6 136 ✔️ +1  38 💤 ±0  0 ±0 
6 421 runs  +7  6 378 ✔️ +7  43 💤 ±0  0 ±0 

Results for commit d3e146b. ± Comparison against base commit 26a5c92.

♻️ This comment has been updated with latest results.

@caalador caalador added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Apr 5, 2023
czp13
czp13 previously approved these changes Apr 5, 2023
Copy link
Contributor

@czp13 czp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me, covering tests as well added.

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@caalador caalador merged commit 8e4659e into main Apr 11, 2023
27 checks passed
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Apr 11, 2023
@caalador caalador deleted the issues/16037_trust_bundle branch April 11, 2023 10:18
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.1.0.alpha3 and is also targeting the upcoming stable 24.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

Provide a way to prevent a dev bundle from being rebuilt
4 participants