Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Watch for theme changes in other Maven modules #16740

Merged
merged 3 commits into from May 11, 2023

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented May 4, 2023

Allows you to do edit the theme in another module in a multi-module project and still have hot reload

@github-actions
Copy link

github-actions bot commented May 4, 2023

Test Results

   987 files  ±  0     987 suites  ±0   1h 23m 51s ⏱️ - 7m 2s
6 255 tests +  1  6 215 ✔️ +  1  40 💤 ±0  0 ±0 
6 494 runs   - 10  6 447 ✔️  - 10  47 💤 ±0  0 ±0 

Results for commit 015762a. ± Comparison against base commit e28129d.

♻️ This comment has been updated with latest results.

@Artur- Artur- force-pushed the watch-for-theme-changes-in-deps branch 7 times, most recently from 298a946 to d4cedf2 Compare May 9, 2023 15:47
@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels May 9, 2023
@Artur- Artur- force-pushed the watch-for-theme-changes-in-deps branch 3 times, most recently from 9206bc2 to 274d88b Compare May 10, 2023 06:10
@Artur- Artur- changed the title feat: Watch for theme changes in other Maven modules when using hotdeploy feat: Watch for theme changes in other Maven modules May 10, 2023
@Artur- Artur- force-pushed the watch-for-theme-changes-in-deps branch 2 times, most recently from 6508863 to 53888ce Compare May 10, 2023 07:53
@Artur- Artur- force-pushed the watch-for-theme-changes-in-deps branch from 53888ce to 4ac74fd Compare May 10, 2023 13:44
@Artur- Artur- requested a review from mcollovati May 10, 2023 13:46
@Artur- Artur- marked this pull request as ready for review May 10, 2023 13:46
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Artur- Artur- merged commit 8f15c54 into main May 11, 2023
27 checks passed
@Artur- Artur- deleted the watch-for-theme-changes-in-deps branch May 11, 2023 07:22
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants