Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm install task should use ClassFinder #16901

Merged
merged 1 commit into from May 29, 2023
Merged

fix: npm install task should use ClassFinder #16901

merged 1 commit into from May 29, 2023

Conversation

caalador
Copy link
Contributor

The TaskRunNpmInstall should use ClassFinder
to load the vaadin-core-versions.json

Fixes #16032

@caalador
fix: npm install task should use ClassFinder
e97ae5c 
The TaskRunNpmInstall should use ClassFinder
to load the vaadin-core-versions.json

Fixes #16032
@caalador caalador requested review from mshabarov and Artur- May 29, 2023 06:38
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Test Results

   992 files  ±  0     992 suites  ±0   1h 25m 38s ⏱️ + 3m 22s
6 299 tests ±  0  6 258 ✔️ ±  0  41 💤 ±0  0 ❌ ±0 
6 552 runs  +16  6 504 ✔️ +16  48 💤 ±0  0 ❌ ±0 

Results for commit e97ae5c. ± Comparison against base commit fe1a378.

@caalador caalador merged commit 00e1678 into main May 29, 2023
26 of 27 checks passed
@caalador caalador deleted the issues/16032-versions-info branch May 29, 2023 07:14
vaadin-bot pushed a commit that referenced this pull request May 29, 2023
@caalador @vaadin-bot
fix: npm install task should use ClassFinder (#16901)
8ec9ce1 
The TaskRunNpmInstall should use ClassFinder
to load the vaadin-core-versions.json

Fixes #16032
vaadin-bot pushed a commit that referenced this pull request May 29, 2023
@caalador @vaadin-bot
fix: npm install task should use ClassFinder (#16901)
020f5d6 
The TaskRunNpmInstall should use ClassFinder
to load the vaadin-core-versions.json

Fixes #16032
@mshabarov
Copy link
Contributor

Just my 5 cents - I did a test with starter and this message doesn't appear anymore.

czp13 pushed a commit that referenced this pull request May 29, 2023
@vaadin-bot @caalador
fix: npm install task should use ClassFinder (#16901) (#16902)
0f7afb9 
The TaskRunNpmInstall should use ClassFinder
to load the vaadin-core-versions.json

Fixes #16032

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
czp13 pushed a commit that referenced this pull request May 29, 2023
@vaadin-bot @caalador
fix: npm install task should use ClassFinder (#16901) (#16903)
9aba71c 
The TaskRunNpmInstall should use ClassFinder
to load the vaadin-core-versions.json

Fixes #16032

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artur- Artur- Artur- approved these changes

@mshabarov mshabarov Awaiting requested review from mshabarov

Assignees
No one assigned
Labels
cherry-picked-24.0 cherry-picked-24.1 prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha1 target/24.1 +1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version information warning when building for production
4 participants
@caalador @mshabarov @vaadin-bot @Artur-