Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update plugins #16911

Merged
merged 2 commits into from Jun 1, 2023
Merged

fix: update plugins #16911

merged 2 commits into from Jun 1, 2023

Conversation

caalador
Copy link
Contributor

Update available plugins
to not get validation issues.

This lessens some of them when
building flow.

partly to #16881

@caalador
fix: update plugins
2f4f1cd 
Update available plugins
to not get validation issues.

This lessens some of them when
building flow.

partly to #16881
@github-actions
Copy link

github-actions bot commented May 30, 2023 •
edited

Test Results

   992 files  ±  0     992 suites  ±0   1h 24m 34s ⏱️ - 2m 29s
6 299 tests ±  0  6 258 ✔️ ±  0  41 💤 ±0  0 ❌ ±0 
6 540 runs   - 12  6 494 ✔️  - 10  46 💤  - 2  0 ❌ ±0 

Results for commit b1422d0. ± Comparison against base commit a9d5f16.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Artur- Artur- mentioned this pull request May 31, 2023
Closed
Artur-

This comment was marked as duplicate.

Sign in to view

Artur-
Artur- requested changes May 31, 2023
View reviewed changes
Copy link
Member

@Artur- Artur- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something fishy here as the api diff build fails with

[ERROR] We have duplicated artifacts attached.
[11:44:09 ]Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (attach-sources) on project flow-commons-upload: Presumably you have configured maven-source-plugn to execute twice times in your build. You have to configure a classifier for at least on of them.

@caalador
Copy link
Contributor Author

I haven't found out yet what the difference is as I can run the api-diff locally without any issues.

@Artur-
Copy link
Member

Artur- commented May 31, 2023

Yeah the build runs the same targets multiple times for some reason

[14:03:56] :	 [Step 7/9] [INFO] --- enforcer:3.3.0:enforce (default-cli) @ flow-commons-upload ---
[14:03:56] :	 [Step 7/9] [INFO] --- build-helper:3.4.0:parse-version (parse-version) @ flow-commons-upload ---
[14:03:56] :	 [Step 7/9] [INFO] --- directory:1.0:highest-basedir (set-root-dir-for-common-lifecycle) @ flow-commons-[14:03:56] :	 [Step 7/9] [INFO] --- enforcer:3.3.0:enforce (check-logging-imports) @ flow-commons-upload ---
[14:03:56] :	 [Step 7/9] [INFO] --- resources:3.3.1:resources (default-resources) @ flow-commons-upload ---
[14:03:56] :	 [Step 7/9] [INFO] --- compiler:3.11.0:compile (default-compile) @ flow-commons-upload ---
[14:03:57] :	 [Step 7/9] [INFO] --- bnd:6.4.0:bnd-process (default) @ flow-commons-upload ---
[14:03:57] :	 [Step 7/9] [INFO] --- resources:3.3.1:testResources (default-testResources) @ flow-commons-upload ---
[14:03:57] :	 [Step 7/9] [INFO] --- compiler:3.11.0:testCompile (default-testCompile) @ flow-commons-upload ---
[14:03:57] :	 [Step 7/9] [INFO] --- surefire:3.1.0:test (default-test) @ flow-commons-upload ---
[14:03:57] :	 [Step 7/9] [INFO] --- jar:3.3.0:jar (default-jar) @ flow-commons-upload ---
[14:03:57] :	 [Step 7/9] [INFO] --- japicmp:0.16.0:cmp (default) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- source:3.3.0:jar-no-fork (attach-sources) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- javadoc:3.5.0:jar (attach-javadocs) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- directory:1.0:highest-basedir (set-root-dir-for-clean-lifecycle) @ flow-commons-upload [14:03:58] :	 [Step 7/9] [INFO] --- clean:3.2.0:clean (default-clean) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- enforcer:3.3.0:enforce (default-cli) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- build-helper:3.4.0:parse-version (parse-version) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- directory:1.0:highest-basedir (set-root-dir-for-common-lifecycle) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- enforcer:3.3.0:enforce (check-logging-imports) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- resources:3.3.1:resources (default-resources) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- compiler:3.11.0:compile (default-compile) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- bnd:6.4.0:bnd-process (default) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- resources:3.3.1:testResources (default-testResources) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- compiler:3.11.0:testCompile (default-testCompile) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- surefire:3.1.0:test (default-test) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- jar:3.3.0:jar (default-jar) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- japicmp:0.16.0:cmp (default) @ flow-commons-upload ---
[14:03:58] :	 [Step 7/9] [INFO] --- source:3.3.0:jar-no-fork (attach-sources) @ flow-commons-upload ---

@Artur-
Copy link
Member

Artur- commented May 31, 2023

.... it was using mvn verify clean install... maybe it works now that it uses mvn clean install only

@caalador caalador merged commit 5191b6e into main Jun 1, 2023
27 checks passed
@caalador caalador deleted the issues/16881-update-plugins branch June 1, 2023 04:15
@ZheSun88 ZheSun88 mentioned this pull request Jun 2, 2023
Merged
vaadin-bot pushed a commit that referenced this pull request Jun 2, 2023
@caalador @vaadin-bot
fix: update plugins (#16911)
2beda94 
Update available plugins
to not get validation issues.

This lessens some of them when
building flow.

touches #16881
vaadin-bot added a commit that referenced this pull request Jun 5, 2023
@vaadin-bot @caalador
fix: update plugins (#16911) (#16950)
970eb95 
Update available plugins
to not get validation issues.

This lessens some of them when
building flow.

touches #16881

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artur- Artur- Artur- approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.1 prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha1 target/24.1 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@caalador @Artur- @vaadin-bot @ZheSun88