chore: add method to skip clean #17080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method to build-frontend plugin that makes it possible to skip cleaning of frontend files from extending plugins.
mcollovati
requested changes
Jun 22, 2023
...-plugins/flow-maven-plugin/src/main/java/com/vaadin/flow/plugin/maven/BuildFrontendMojo.java
Outdated
Show resolved
Hide resolved
mcollovati
previously approved these changes
Jun 22, 2023
|
Yes, Gradle has the same functionality. Added the method there also so it can be overridden to not do the cleaning if necessary. |
mcollovati
approved these changes
Jun 22, 2023
mcollovati
requested changes
Jun 22, 2023
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt
Outdated
Show resolved
Hide resolved
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt
Outdated
Show resolved
Hide resolved
mcollovati
approved these changes
Jun 22, 2023
mcollovati
requested changes
Jun 23, 2023
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinBuildFrontendTask.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Collovati <marco@vaadin.com>
|
Kudos, SonarCloud Quality Gate passed!
|
mcollovati
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to build-frontend
plugin that makes it possible
to skip cleaning of frontend
files from extending plugins.