fix: Not generate chunks with the same content (#17511)(CP: 24.1) #17522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks if a chunk has already been considered for a given list of imported modules and scripts. If so, it doesn't generate a new file, but only updates the the import file, linking all the route class hashes with the same chunk file. Also adds dependencyTriggers and eager fields to the ChunkInfo hashCode and equals, as ChunkInfo is used widely in maps. Adds extra debug logging to AbstractUpdateImports to understand better what takes most of the time in large projects. Related-to #17234 (cherry picked from commit 74196a0)
caalador
previously approved these changes
Aug 31, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if a chunk has already been considered for a given list of imported modules and scripts. If so, it doesn't generate a new file, but only updates the the import file, linking all the route class hashes with the same chunk file.
Also adds dependencyTriggers and eager fields to the ChunkInfo hashCode and equals, as ChunkInfo is used widely in maps.
Adds extra debug logging to AbstractUpdateImports to understand better what takes most of the time in large projects.
Related-to #17234
(cherry picked from commit 74196a0)