fix: improve error message when a component is moved from one UI to another. #18019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sister function for Element.get(StateNode), but returns an empty Optional instead of throwing an exception
mcollovati
changed the title
mcollovati
requested changes
Nov 13, 2023
flow-server/src/main/java/com/vaadin/flow/internal/StateNode.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/internal/StateNode.java
Outdated
Show resolved
Hide resolved
|
Some minor changes requested, but LGTM. Great job @mvysny |
|
Thank you @mcollovati , all items should now be resolved. |
|
Kudos, SonarCloud Quality Gate passed!
|
czp13
reviewed
Nov 13, 2023
mcollovati
approved these changes
Nov 13, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
…nother. (#18019) * feat: Add ElementUtil.from(StateNode) which returns Optional<Element> Sister function for Element.get(StateNode), but returns an empty Optional instead of throwing an exception * fix: improve error message when a component is moved from one UI to another. Fixes #9376 * chore: mention both createLocation and attachLocation in the exception message * chore: mention both createLocation and attachLocation in the exception message * chore: minor fixes in messages
|
Hi @mvysny and @mvysny, when i performed cherry-pick to this commit to 24.1, i have encountered the following issue. Can you take a look and pick it manually? |
mcollovati
pushed a commit
that referenced
this pull request
Nov 17, 2023
…nother. (#18019) * feat: Add ElementUtil.from(StateNode) which returns Optional<Element> Sister function for Element.get(StateNode), but returns an empty Optional instead of throwing an exception * fix: improve error message when a component is moved from one UI to another. Fixes #9376 * chore: mention both createLocation and attachLocation in the exception message * chore: mention both createLocation and attachLocation in the exception message * chore: minor fixes in messages
vaadin-bot
added a commit
that referenced
this pull request
Nov 17, 2023
…nother. (#18019) (CP: 24.2) (#18060) * fix: improve error message when a component is moved from one UI to another. (#18019) * feat: Add ElementUtil.from(StateNode) which returns Optional<Element> Sister function for Element.get(StateNode), but returns an empty Optional instead of throwing an exception * fix: improve error message when a component is moved from one UI to another. Fixes #9376 * chore: mention both createLocation and attachLocation in the exception message * chore: mention both createLocation and attachLocation in the exception message * chore: minor fixes in messages * test: reset ComponentTracker.productionMode static field (#18028) Prevents unexpected situation in ComponentTest caused by the ComponenTracker.productionMode flag being initialized to true by some other tests. In particular, cannotMoveComponentsToOtherUI test may fail because the exception message is different in development and production modes. --------- Co-authored-by: Martin Vysny <mavi@vaadin.com> Co-authored-by: Marco Collovati <marco@vaadin.com>
mcollovati
added a commit
that referenced
this pull request
Nov 17, 2023
…nother. (#18019) (CP: 24.1) (#18061) * fix: improve error message when a component is moved from one UI to another. (#18019) * feat: Add ElementUtil.from(StateNode) which returns Optional<Element> Sister function for Element.get(StateNode), but returns an empty Optional instead of throwing an exception * fix: improve error message when a component is moved from one UI to another. Fixes #9376 * chore: mention both createLocation and attachLocation in the exception message * chore: mention both createLocation and attachLocation in the exception message * chore: minor fixes in messages * test: reset ComponentTracker.productionMode static field (#18028) Prevents unexpected situation in ComponentTest caused by the ComponenTracker.productionMode flag being initialized to true by some other tests. In particular, cannotMoveComponentsToOtherUI test may fail because the exception message is different in development and production modes. --------- Co-authored-by: Martin Vysny <mavi@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve error message when a component is moved from one UI to another.
Fixes #9376
Type of change
Checklist
Additional for
Featuretype of change