Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: reject AppShell classes which extend Component #18169

Merged
merged 7 commits into from
Dec 1, 2023
Merged

feat!: reject AppShell classes which extend Component #18169

merged 7 commits into from
Dec 1, 2023

Conversation

mvysny
Copy link
Member

@mvysny mvysny commented Nov 30, 2023

Description

AppShellRegistry now rejects app shell class which extends Component.

Fixes #18012

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mvysny mvysny changed the title #18012 feat!: reject AppShells classes which extend Components. #18012 feat!: reject AppShell classes which extend Components. Nov 30, 2023
@mvysny mvysny changed the title #18012 feat!: reject AppShell classes which extend Components. #18012 feat!: reject AppShell classes which extend Component Nov 30, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited

Test Results

1 043 files  ±  0  1 043 suites  ±0   1h 17m 6s ⏱️ - 2m 3s
6 715 tests +  1  6 670 ✔️ +  1  45 💤 ±0  0 ❌ ±0 
6 962 runs   - 49  6 909 ✔️  - 47  53 💤  - 2  0 ❌ ±0 

Results for commit 04bcea5. ± Comparison against base commit 0e729e0.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Nov 30, 2023
@mcollovati mcollovati changed the title #18012 feat!: reject AppShell classes which extend Component feat!: reject AppShell classes which extend Component Nov 30, 2023
@mvysny mvysny mentioned this pull request Dec 1, 2023
Merged
@mvysny mvysny enabled auto-merge (squash) December 1, 2023 07:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati mcollovati enabled auto-merge (squash) December 1, 2023 08:09
@mcollovati mcollovati merged commit 0779763 into main Dec 1, 2023
26 checks passed
@mcollovati mcollovati deleted the feat/18012 branch December 1, 2023 08:17
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

rodolforfq pushed a commit that referenced this pull request Feb 8, 2024
@mvysny @rodolforfq
feat!: reject AppShell classes which extend Component (#18169)
6c5d211 
Fixes #18012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
Contribution PRs coming from the community or external to the team prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha1 +0.0.1
Projects
Vaadin Flow ongoing work (Vaadin 10+)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow Component to implement AppShellConfigurator
3 participants
@mvysny @vaadin-bot @mcollovati