feat: support DataProviderWrapper better in AbstractDataView #18317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds in `AbstractDataView` a better support for wrapper data providers that implements `DataProviderWrapper`. `AbstractDataView` won't throw exception anymore if wrapped data container is supported by the data view implementation. Adds public `getWrappedDataProvider` method in `DataProviderWrapper`. Related-to: #18088
mshabarov
previously approved these changes
Dec 15, 2023
mshabarov
reviewed
Dec 15, 2023
flow-data/src/main/java/com/vaadin/flow/data/provider/DataProviderWrapper.java
Outdated
Show resolved
Hide resolved
|
mshabarov
approved these changes
Dec 15, 2023
mshabarov
deleted the
feat/abstractdataview-support-dataprovider-wrapper
branch
|
This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
rodolforfq
pushed a commit
that referenced
this pull request
Feb 8, 2024
* feat: support DataProviderWrapper better in AbstractDataView Adds in `AbstractDataView` a better support for wrapper data providers that implements `DataProviderWrapper`. `AbstractDataView` won't throw exception anymore if wrapped data container is supported by the data view implementation. Adds public `getWrappedDataProvider` method in `DataProviderWrapper`. Related-to: #18088 * chore: changed getWrappedDataProvider to package-private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in
AbstractDataViewa better support for wrapper data providers that implementsDataProviderWrapper.AbstractDataViewwon't throw exception anymore if wrapped data container is supported by the data view implementation. Adds publicgetWrappedDataProvidermethod inDataProviderWrapper.Related-to: #18088