-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Write source information for React components defined in the project #18470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
write-react-function-def-location
branch
from
January 16, 2024 11:28
f57b840
to
5a281d1
Compare
Artur-
force-pushed
the
write-react-function-def-location
branch
from
January 17, 2024 08:05
5a281d1
to
093cbf3
Compare
Artur-
force-pushed
the
write-react-function-def-location
branch
from
January 22, 2024 15:55
f96ab60
to
e729dcc
Compare
…oject When transpiling tsx/jsx to ts/js, Babel writes the source information for where components are used. This adds the information about where components are defined.
Artur-
force-pushed
the
write-react-function-def-location
branch
from
January 22, 2024 16:13
e729dcc
to
6f1d48b
Compare
caalador
reviewed
Jan 23, 2024
flow-server/src/main/resources/plugins/react-function-location-plugin/package.json
Outdated
Show resolved
Hide resolved
.../src/main/resources/plugins/react-function-location-plugin/react-function-location-plugin.js
Show resolved
Hide resolved
flow-tests/test-frontend/vite-basics/src/test/java/com/vaadin/viteapp/ReactComponentsIT.java
Outdated
Show resolved
Hide resolved
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
mshabarov
approved these changes
Jan 24, 2024
rodolforfq
pushed a commit
that referenced
this pull request
Feb 8, 2024
…oject (#18470) * feat: Write source information for React components defined in the project When transpiling tsx/jsx to ts/js, Babel writes the source information for where components are used. This adds the information about where components are defined. * Test * format * Fix review comments
This ticket/PR has been released with Vaadin 24.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transpiling tsx/jsx to ts/js, Babel writes the source information for where components are used. This adds the information about where components are defined.