Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Write source information for React components defined in the project #18470

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jan 16, 2024

When transpiling tsx/jsx to ts/js, Babel writes the source information for where components are used. This adds the information about where components are defined.

@Artur- Artur- force-pushed the write-react-function-def-location branch from f57b840 to 5a281d1 Compare January 16, 2024 11:28
Copy link

github-actions bot commented Jan 16, 2024

Test Results

1 092 files  + 1  1 092 suites  +1   1h 19m 59s ⏱️ + 1m 8s
6 808 tests + 1  6 762 ✅ +1  46 💤 ±0  0 ❌ ±0 
7 155 runs  +10  7 097 ✅ +9  58 💤 +1  0 ❌ ±0 

Results for commit 01d55cc. ± Comparison against base commit fd9d8c9.

♻️ This comment has been updated with latest results.

@Artur- Artur- force-pushed the write-react-function-def-location branch from 5a281d1 to 093cbf3 Compare January 17, 2024 08:05
@Artur- Artur- force-pushed the write-react-function-def-location branch from f96ab60 to e729dcc Compare January 22, 2024 15:55
…oject

When transpiling tsx/jsx to ts/js, Babel writes the source information for where components are used. This adds the information about where components are defined.
@Artur- Artur- force-pushed the write-react-function-def-location branch from e729dcc to 6f1d48b Compare January 22, 2024 16:13
@Artur- Artur- marked this pull request as ready for review January 22, 2024 16:14
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshabarov mshabarov merged commit 1ee4b41 into main Jan 24, 2024
26 checks passed
@mshabarov mshabarov deleted the write-react-function-def-location branch January 24, 2024 15:24
rodolforfq pushed a commit that referenced this pull request Feb 8, 2024
…oject (#18470)

* feat: Write source information for React components defined in the project

When transpiling tsx/jsx to ts/js, Babel writes the source information for where components are used. This adds the information about where components are defined.

* Test

* format

* Fix review comments
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants