Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: rename default validator api #18657

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Feb 8, 2024

Rename default validator toggling API. Also fixes methods in binding to set/return Boolean instead of boolean.

Copy link

github-actions bot commented Feb 8, 2024

Test Results

1 092 files  ±0  1 092 suites  ±0   1h 20m 15s ⏱️ -47s
6 854 tests ±0  6 808 ✅ ±0  46 💤 ±0  0 ❌ ±0 
7 208 runs  +2  7 150 ✅ +2  58 💤 ±0  0 ❌ ±0 

Results for commit 4d80633. ± Comparison against base commit 7aa0cd0.

♻️ This comment has been updated with latest results.

mshabarov
mshabarov previously approved these changes Feb 8, 2024
@mshabarov mshabarov changed the title Fix/rename default validator api fix!: rename default validator api Feb 8, 2024
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tepi tepi merged commit e73d130 into main Feb 9, 2024
26 checks passed
@tepi tepi deleted the fix/rename-default-validator-api branch February 9, 2024 09:58
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha4 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants