Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add file system router plugin for vite #18878

Merged
merged 3 commits into from
Mar 4, 2024
Merged

feat: add file system router plugin for vite #18878

merged 3 commits into from
Mar 4, 2024

Conversation

tltv
Copy link
Member

@tltv tltv commented Mar 4, 2024

Adds vitePluginFileSystemRouter to Vite plugins by default when React and Hilla is in use.

Fixes: #18832

@tltv
feat: add file system router plugin for vite
0dcbff7 
Adds vitePluginFileSystemRouter to Vite plugins by default when React and Hilla is in use.

Fixes: #18832
@tltv tltv requested a review from mshabarov March 4, 2024 12:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited

Test Results

1 096 files  ± 0  1 096 suites  ±0   1h 17m 17s ⏱️ - 2m 22s
6 963 tests + 2  6 914 ✅ + 2  49 💤 ±0  0 ❌ ±0 
7 311 runs  +21  7 250 ✅ +19  61 💤 +2  0 ❌ ±0 

Results for commit 988d1a6. ± Comparison against base commit ba8e6f5.

♻️ This comment has been updated with latest results.

tltv added 2 commits March 4, 2024 15:31
@tltv
chore: removed dep from default vite packages
d63cfa9 
Hilla packages adds the dep in dependencies already.
@tltv
test: added tests
988d1a6
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tltv tltv marked this pull request as ready for review March 4, 2024 14:17
mshabarov
mshabarov approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@mshabarov mshabarov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, Vite generated now has this plugin and views.js is generated. If Hilla isn't used, it's not added.

@mshabarov mshabarov merged commit 260fa5f into main Mar 4, 2024
26 checks passed
@mshabarov mshabarov deleted the feat/18832-add-fs-router-plugin branch March 4, 2024 16:09
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
Released with Vaadin 24.4.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FileSystem-based router plugin by default when frontend build is needed
3 participants
@tltv @vaadin-bot @mshabarov