feat: Pass Java class info to browser in dev mode #18892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
reviewed
Mar 7, 2024
flow-client/src/main/java/com/vaadin/client/ApplicationConnection.java
Outdated
Show resolved
Hide resolved
Artur-
force-pushed
the
java-class-in-dev-mode
branch
from
b8e0462
to
f8a5f81
Compare
Artur-
commented
Mar 14, 2024
flow-server/src/main/java/com/vaadin/flow/component/ComponentUtil.java
Outdated
Show resolved
Hide resolved
Artur-
force-pushed
the
java-class-in-dev-mode
branch
2 times, most recently
from
24e01ac
to
8aa3c7a
Compare
|
As this info is only needed in real development mode, I changed the patch to ignore all other situations (missing session, missing configuration etc). Then it should not even require any test changes.. |
…s and they do not need the class name
Artur-
force-pushed
the
java-class-in-dev-mode
branch
from
8aa3c7a
to
75549db
Compare
…e locked when the UI is attached to the session
caalador
reviewed
Mar 14, 2024
flow-client/src/main/java/com/vaadin/client/ApplicationConnection.java
Outdated
Show resolved
Hide resolved
|
caalador
approved these changes
Mar 14, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha15 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.