New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add method for checking if annotation based security is used #19038
Conversation
* @return {@code true} if an {@link AnnotatedViewAccessChecker} is in use, | ||
* {@code false} otherwise | ||
*/ | ||
public boolean isUsingAnnotatedViewAccessChecker() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be a more generic method like isUsingAccessChecker(Class<? extends NavigationAccessChecker> clazz)
?
I wonder if there might be a use case for checking for RoutePathAccessChecker
, for example.
If possible (and it is reasonable) I would prevent having this class filled with isUsingSometing()
methods.
If it does not make sense, I'm ok with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then the question is, should it be ”is” or ”get”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it a more generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then the question is, should it be ”is” or ”get”
get
because there may be a use case where the checker instance could be used outside the NavigationAccessControl?
flow-server/src/main/java/com/vaadin/flow/server/auth/NavigationAccessControl.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
No description provided.