fix: detach should be sent for node (#17695) (CP: 23.5) #19051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not clean the node id or hasAttached state too early as then we do not send the detach event for the node. Fixes #17653
vaadin-review-bot
previously approved these changes
Mar 27, 2024
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot] |
) Enables moving a component to another UI by just calling Element.removeFromTree() and then adding the component to the other UI. Fixes #18390 --------- Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Tatu Lund <tatu@vaadin.com>
|
vaadin-review-bot
approved these changes
Mar 27, 2024
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot] |
|
This ticket/PR has been released with Vaadin 23.5.0.alpha1 and is also targeting the upcoming stable 23.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.