Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore hasBeenAttached on resync (#19023) #19068

Merged
merged 2 commits into from Apr 2, 2024
Merged

fix: restore hasBeenAttached on resync (#19023) #19068

merged 2 commits into from Apr 2, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Mar 28, 2024

Fixes #19023

@tepi tepi marked this pull request as draft March 28, 2024 13:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited

Test Results

1 091 files  ±0  1 091 suites  ±0   1h 24m 14s ⏱️ + 1m 20s
6 934 tests ±0  6 885 ✅ ±0  49 💤 ±0  0 ❌ ±0 
7 272 runs   - 9  7 211 ✅  - 9  61 💤 ±0  0 ❌ ±0 

Results for commit 25b1a50. ± Comparison against base commit b6522bf.

♻️ This comment has been updated with latest results.

@tepi tepi marked this pull request as ready for review April 2, 2024 10:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@caalador caalador merged commit b83dfff into main Apr 2, 2024
26 checks passed
@caalador caalador deleted the fix/restore-hasbeenattached-after-resync branch April 2, 2024 11:30
vaadin-bot pushed a commit that referenced this pull request Apr 2, 2024
@tepi @vaadin-bot
fix: restore hasBeenAttached on resync (#19023) (#19068)
3be6f48 
Fixes #19023
vaadin-bot added a commit that referenced this pull request Apr 2, 2024
@vaadin-bot @tepi
fix: restore hasBeenAttached on resync (#19023) (#19068) (#19079)
b29bf42 
Fixes #19023

Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha19 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.3 prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha19 target/24.3 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detach listeners not called when closing tab after resynchronization
3 participants
@tepi @vaadin-bot @caalador