fix: Query in path #19087
Merged
fix: Query in path #19087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mistaken add of query parameters into the route breaking route resolution when navigating thrhough link. part of #19080
caalador
force-pushed
the
issues/19080-route-not-ofund
branch
from
22c8027
to
2f678b1
Compare
tltv
reviewed
Apr 3, 2024
|
Actually this might be a problem in the server side route resolver instead of a problem getting the query. I can only see a couple tests that test the href for routerlink, but nothing that would test actually navigating with the query and that is what fails now. |
|
Now it should be ok and there are tests in place for the navigation. |
tltv
requested changes
Apr 3, 2024
flow-server/src/main/resources/com/vaadin/flow/server/frontend/Flow.tsx
Outdated
Show resolved
Hide resolved
flow-server/src/main/resources/com/vaadin/flow/server/frontend/Flow.tsx
Outdated
Show resolved
Hide resolved
|
tltv
approved these changes
Apr 4, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha21 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mistaken add of query
parameters into the route
breaking route resolution
when navigating thrhough link.
fixes #19080