fix: normalize and replace line separator in node task lock file

[mcollovati]

Normalizes and replaces line separators potentially present in the process command line before writing the lock file, so that it will contain only two lines. Same normalization is applied when getting the command line for the process identified by the pid in the lock file before comparing it with the value stored in the lock file.

Fixes #19091

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[mcollovati]

Manually tested this way:

Without the patch, run maven with a parameter that spans over multiple rows, e.g.

mvn -Dxxxx="sdfdsf
dfgdfgdf
dfgdfgdfg
dfgdfg
" process-resources

In the console log, you should see the error Error releasing lock file .... and the lock file is not deleted.

With the patch, the error is not shown.

Additional test:

1. Put a break point in NodeTasks.writeLockFile on the Files.write() instruction
2. Run the above maven command in debug mode (mvnDebug)
3. When the debugger reaches the breakpoint, proceed until the lock file is written and then wait
4. On another terminal, run the same maven command, without debug mode. On the console, you should see something like Waiting for a previous instance of NodeTasks (pid: 84845) to finish...
5. Detach the debugger so that the command on the first terminal can complete
6. Check that also the command launched on the other terminal completes without errors and the lock file is deleted

[github-actions]

Test Results

1 099 files  ±0  1 099 suites  ±0   1h 24m 7s ⏱️ - 1m 57s
6 938 tests ±0  6 889 ✅ ±0  49 💤 ±0  0 ❌ ±0 
7 302 runs   - 2  7 241 ✅  - 2  61 💤 ±0  0 ❌ ±0 

Results for commit de6d624. ± Comparison against base commit eb30c25.

[mcollovati]

So far, I have no good idea on how to implement a proper test for this change

[caalador]

I don't see a good way to test this either...

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.4.0.alpha21 and is also targeting the upcoming stable 24.4.0 version.