fix: filter hilla and copilot packages better

[tltv]

Filter "com/vaadin/hilla" and "com/vaadin/copilot" packages by default from the class scanner in VaadinServletContextInitializer and include only what is really needed: com.vaadin.copilot.startup and com.vaadin.hilla.startup. This speeds up mostly reload time and also startup time a bit.

Related-to: #19112

[github-actions]

Test Results

1 099 files  ± 0  1 099 suites  ±0   1h 28m 4s ⏱️ + 4m 33s
6 944 tests ± 0  6 895 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 273 runs   - 36  7 212 ✅  - 36  61 💤 ±0  0 ❌ ±0 

Results for commit 2b3b4ee. ± Comparison against base commit 27110fa.

♻️ This comment has been updated with latest results.

[caalador]

The only thing here is how do we bring up the issue that if copilot adds some other scan required parts?
Hilla would seem to use the startup package which makes it a non issue, but copilot does not. Should we ask copilot to also use a dedicated pacakge for startup and scanning?

[tltv]

The only thing here is how do we bring up the issue that if copilot adds some other scan required parts? Hilla would seem to use the startup package which makes it a non issue, but copilot does not. Should we ask copilot to also use a dedicated pacakge for startup and scanning?

#19117 has a solution for that. It would let copilot and hilla to define what packages or classes to include/exclude.

[tltv]

Since we don't have #19117 done yet and no schedule for it, having a dedicated package like com.vaadin.copilot.startup for CopilotIndexHtmlLoader and CopilotLoader can make sense. No need to touch Flow then when adding new loaders in Copilot. Just add them in com.vaadin.copilot.startup and Flow scans them. Otherwise new loaders (or other classes that Flow should scan) would need to be added to Flow's VaadinServletContextInitializer.

But is it worth to refactor package names in Copilot? If there's no plans to add new classes that Flow should scan, then waiting that #19117 is done could make more sense. Pinging @MarcinVaadin for better insight regarding Copilot.

[Artur-]

Makes sense to refactor copilot to use com.vaadin.copilot.startup rather than list classes here

[tltv]

Added com.vaadin.copilot.startup already. Refactoring copilot can happen anytime and no need to get back to change Flow. But we need a ticket for that in Copilot.

[Artur-]

I can fix copilot as part of the next Flow upgrade

[Artur-]

You can remove the copilot classes also already

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud