feat:allow explicitly reveiving certain dom events for inert elements

flow-server/src/main/java/com/vaadin/flow/dom/DomListenerRegistration.java

@@ -391,4 +391,14 @@ default public DomListenerRegistration preventDefault() {
         return this;
     }
 
+    /**
+     * Configures the event listener to bypass the server side security checks
+     * for modality. Handle with care! Can be ok when transferring data from
+     * "non-ui" component events through the Element API, like e.g. geolocation
+     * events.
+     *
+     * @return the DomListenerRegistration for further configuration
+     */
+    public DomListenerRegistration allowInert();
+
 }

flow-server/src/main/java/com/vaadin/flow/internal/nodefeature/ElementListenerMap.java

@@ -15,20 +15,6 @@
  */
 package com.vaadin.flow.internal.nodefeature;
 
-import java.io.Serializable;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.EnumSet;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Objects;
-import java.util.Set;
-import java.util.function.Function;
-import java.util.stream.Stream;
-
 import com.vaadin.flow.dom.DebouncePhase;
 import com.vaadin.flow.dom.DisabledUpdateMode;
 import com.vaadin.flow.dom.DomEvent;
@@ -39,10 +25,24 @@
 import com.vaadin.flow.internal.JsonUtils;
 import com.vaadin.flow.internal.StateNode;
 import com.vaadin.flow.shared.JsonConstants;
-
 import elemental.json.Json;
 import elemental.json.JsonObject;
 import elemental.json.JsonValue;
+import org.slf4j.LoggerFactory;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.EnumSet;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.function.Function;
+import java.util.stream.Stream;
 
 /**
  * Map of DOM events with server-side listeners. The key set of this map
@@ -114,6 +114,7 @@ private static class DomEventListenerWrapper
         private int debounceTimeout = 0;
         private EnumSet<DebouncePhase> debouncePhases = NO_TIMEOUT_PHASES;
         private List<SerializableRunnable> unregisterHandlers;
+        private boolean allowIntert;
 
         private DomEventListenerWrapper(ElementListenerMap listenerMap,
                 String type, DomEventListener origin) {
@@ -265,6 +266,12 @@ private boolean isPropertySynchronized(String propertyName) {
                     .contains(JsonConstants.SYNCHRONIZE_PROPERTY_TOKEN
                             + propertyName);
         }
+
+        @Override
+        public DomListenerRegistration allowInert() {
+            allowIntert = true;
+            return this;
+        }
     }
 
     /**
@@ -427,7 +434,9 @@ public void fireEvent(DomEvent event) {
         if (listeners == null) {
             return;
         }
-        boolean isElementEnabled = event.getSource().isEnabled();
+        final boolean isElementEnabled = event.getSource().isEnabled();
+        final boolean inert = event.getSource().getNode().isInert();
+
         List<DomEventListenerWrapper> typeListeners = listeners
                 .get(event.getType());
         if (typeListeners == null) {
@@ -436,6 +445,15 @@ public void fireEvent(DomEvent event) {
 
         List<DomEventListener> listeners = new ArrayList<>();
         for (DomEventListenerWrapper wrapper : typeListeners) {
+            if (inert && !wrapper.allowIntert) {
+                // drop as inert
+                LoggerFactory.getLogger(ElementListenerMap.class.getName())
+                        .info("Ignored listener invocation from "
+                                + "the client side for an inert {} element",
+                                event.getSource().getTag());
+                continue;
+            }
+
             if ((isElementEnabled
                     || DisabledUpdateMode.ALWAYS.equals(wrapper.mode))
                     && wrapper.matchesFilter(event.getEventData())

flow-server/src/main/java/com/vaadin/flow/server/communication/rpc/AbstractRpcInvocationHandler.java

@@ -23,7 +23,9 @@
 import com.vaadin.flow.component.UI;
 import com.vaadin.flow.component.UI.BrowserLeaveNavigationEvent;
 import com.vaadin.flow.component.UI.BrowserNavigateEvent;
+import com.vaadin.flow.internal.NodeOwner;
 import com.vaadin.flow.internal.StateNode;
+import com.vaadin.flow.internal.StateTree;
 import com.vaadin.flow.shared.JsonConstants;
 
 import elemental.json.JsonObject;
@@ -62,12 +64,12 @@ public Optional<Runnable> handle(UI ui, JsonObject invocationJson) {
         // ignore RPC requests from the client side for the nodes that are
         // invisible, disabled or inert
         if (node.isInactive()) {
-            getLogger().trace("Ignored RPC for invocation handler '{}' from "
+            getLogger().info("Ignored RPC for invocation handler '{}' from "
                     + "the client side for an inactive (disabled or invisible) node id='{}'",
                     getClass().getName(), node.getId());
             return Optional.empty();
         } else if (!allowInert(ui, invocationJson) && node.isInert()) {
-            getLogger().trace(
+            getLogger().info(
                     "Ignored RPC for invocation handler '{}' from "
                             + "the client side for an inert node id='{}'",
                     getClass().getName(), node.getId());

flow-server/src/main/java/com/vaadin/flow/server/communication/rpc/EventRpcHandler.java

@@ -17,6 +17,7 @@
 
 import java.util.Optional;
 
+import com.vaadin.flow.component.UI;
 import com.vaadin.flow.dom.DomEvent;
 import com.vaadin.flow.dom.Element;
 import com.vaadin.flow.internal.StateNode;
@@ -64,4 +65,9 @@ public Optional<Runnable> handleNode(StateNode node,
         return Optional.empty();
     }
 
+    @Override
+    protected boolean allowInert(UI ui, JsonObject invocationJson) {
+        // handled separately in ElementListenerMap
+        return true;
+    }
 }

flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

@@ -29,6 +29,7 @@
 import java.util.stream.Collectors;
 import java.util.stream.DoubleStream;
 
+import com.vaadin.flow.internal.nodefeature.InertData;
 import net.jcip.annotations.NotThreadSafe;
 import org.junit.Assert;
 import org.junit.Test;
@@ -382,6 +383,33 @@ public void listenerReceivesEvents() {
         Assert.assertEquals(1, listenerCalls.get());
     }
 
+    @Test
+    public void listenerReceivesEventsWithAllowIntert() {
+        Element e = ElementFactory.createDiv();
+        // Inert the node, verify events no more passed through
+        InertData inertData = e.getNode().getFeature(InertData.class);
+        inertData.setInertSelf(true);
+        inertData.generateChangesFromEmpty();
+
+        AtomicInteger listenerCalls = new AtomicInteger(0);
+        DomEventListener myListener = event -> listenerCalls.incrementAndGet();
+
+        DomListenerRegistration domListenerRegistration = e
+                .addEventListener("click", myListener);
+        Assert.assertEquals(0, listenerCalls.get());
+        e.getNode().getFeature(ElementListenerMap.class)
+                .fireEvent(new DomEvent(e, "click", Json.createObject()));
+        // Event should not go through
+        Assert.assertEquals(0, listenerCalls.get());
+
+        // Now should pass inert check and get notified
+        domListenerRegistration.allowInert();
+        e.getNode().getFeature(ElementListenerMap.class)
+                .fireEvent(new DomEvent(e, "click", Json.createObject()));
+        Assert.assertEquals(1, listenerCalls.get());
+
+    }
+
     @Test
     public void getPropertyDefaults() {
         Element element = ElementFactory.createDiv();

flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/BrowserWindowResizeView.java

@@ -15,7 +15,9 @@
  */
 package com.vaadin.flow.uitest.ui;
 
+import com.vaadin.flow.component.UI;
 import com.vaadin.flow.component.html.Div;
+import com.vaadin.flow.component.html.NativeButton;
 import com.vaadin.flow.router.Route;
 import com.vaadin.flow.uitest.servlet.ViewTestLayout;