Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include filesystem dependencies in gradle plugin class finder (#19287) (CP: 24.4) #19301

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: include filesystem dependencies in gradle plugin class finder (#19287) (CP: 24.4) #19301

merged 1 commit into from
May 3, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@mcollovati @vaadin-bot
fix: include filesystem dependencies in gradle plugin class finder (#…
b17bacf 
…19287)

Gradle plugin builds a class finder upon the JAR files obtained through
the project dependencies resolved artifacts, that however does not include
filesystem dependencies.
This change adds filesystem dependencis to the list of project JAR files
provided to the class finder.

Fixes #19024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Test Results

1 099 files  ± 0  1 099 suites  ±0   1h 20m 56s ⏱️ +35s
7 009 tests ± 0  6 960 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 385 runs  +33  7 324 ✅ +33  61 💤 ±0  0 ❌ ±0 

Results for commit b17bacf. ± Comparison against base commit 63e6dfd.

@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels May 3, 2024
@mcollovati mcollovati enabled auto-merge (squash) May 3, 2024 11:59
@mcollovati mcollovati merged commit f4155bb into 24.4 May 3, 2024
26 checks passed
@mcollovati mcollovati deleted the cherry-pick-19287-to-24.4-1714733240255 branch May 3, 2024 11:59
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.0.beta2 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.beta2 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vaadin-bot @mcollovati