Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include filesystem dependencies in gradle plugin class finder (#19287) (CP: 24.3) #19302

Merged
merged 2 commits into from
May 3, 2024
Merged

fix: include filesystem dependencies in gradle plugin class finder (#19287) (CP: 24.3) #19302

merged 2 commits into from
May 3, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@mcollovati @vaadin-bot
fix: include filesystem dependencies in gradle plugin class finder (#…
418ce3d 
…19287)

Gradle plugin builds a class finder upon the JAR files obtained through
the project dependencies resolved artifacts, that however does not include
filesystem dependencies.
This change adds filesystem dependencis to the list of project JAR files
provided to the class finder.

Fixes #19024
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) May 3, 2024 10:54
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited

Test Results

1 052 files  ±0  1 052 suites  ±0   1h 15m 16s ⏱️ + 1m 9s
6 807 tests ±0  6 762 ✅ ±0  45 💤 ±0  0 ❌ ±0 
7 119 runs   - 3  7 063 ✅  - 3  56 💤 ±0  0 ❌ ±0 

Results for commit be94f52. ± Comparison against base commit cc1e1be.

♻️ This comment has been updated with latest results.

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vaadin-bot vaadin-bot merged commit 668e0c8 into 24.3 May 3, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-19287-to-24.3-1714733255307 branch May 3, 2024 12:05
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
Released with Vaadin 24.3.11 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaadin-bot @vaadin-review-bot @mcollovati