Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload flow after hmr reload in dev mode #19323

Merged
merged 1 commit into from
May 10, 2024

Conversation

caalador
Copy link
Contributor

@caalador caalador commented May 7, 2024

Reset and reload flow when a
template hrm reload happens.

Fixes #19291

Copy link

github-actions bot commented May 7, 2024

Test Results

1 101 files  ± 0  1 101 suites  ±0   1h 21m 55s ⏱️ - 1m 7s
7 004 tests ± 0  6 955 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 351 runs   - 27  7 290 ✅  - 27  61 💤 ±0  0 ❌ ±0 

Results for commit 74861c8. ± Comparison against base commit fe30566.

♻️ This comment has been updated with latest results.

Reset and reload flow when a
template hrm reaload happens.
@caalador caalador force-pushed the issues/19291-reload-after-hmr branch from 38d2c00 to 74861c8 Compare May 8, 2024 06:16
@caalador caalador marked this pull request as ready for review May 8, 2024 06:18
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mshabarov mshabarov merged commit 03f3028 into main May 10, 2024
26 of 30 checks passed
@mshabarov mshabarov deleted the issues/19291-reload-after-hmr branch May 10, 2024 09:09
vaadin-bot pushed a commit that referenced this pull request May 10, 2024
Reset and reload flow when a
template hrm reload happens.

Fixes #19291
vaadin-bot added a commit that referenced this pull request May 10, 2024
Reset and reload flow when a
template hrm reload happens.

Fixes #19291

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In a hybrid application, Flow fails after doing HMR and reloading Flow.tsx
3 participants