Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: rename createWebComponent method (#19309) (CP: 24.4) #19356

Merged
merged 1 commit into from
May 13, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* fix!: rename createWebComponent method

Rename the createWebComponent function
as the create gives the impression that
the function is heavy.

* renameMethod to reactElement

---------

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) May 13, 2024 07:00
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Test Results

1 100 files  ± 0  1 100 suites  ±0   1h 19m 13s ⏱️ -1s
7 001 tests ± 0  6 952 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 374 runs  +10  7 313 ✅ +10  61 💤 ±0  0 ❌ ±0 

Results for commit abc7cc2. ± Comparison against base commit e50bf4e.

@vaadin-bot vaadin-bot merged commit e09dd4f into 24.4 May 13, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-19309-to-24.4-1715583166097 branch May 13, 2024 07:08
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.0.beta3 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants