Fix HasUrlParameter serialization and deserialization

[caalador]

Fixes urlParameter deserialization to work with all supported types.
Fixes serialization for getUrl.

---

This change is 

[caalador]

This will fix demo-static-menu-router blogs Internal error.

[denis-anisimov]

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 7 unresolved discussions.

---

flow-server/src/main/java/com/vaadin/router/HasUrlParameter.java, line 77 at r2 (raw file):

if (!parameterType.isAssignableFrom(String.class)) {

Quoted 4 lines of code…

> throw new UnsupportedOperationException( > "Wildcard parameter can only be for String type by default. Implement `deserializeUrlParameters` for class " > + this.getClass().getName()); > }

This code may be is going to be evolved. So please extract this into a separate method.

---

flow-server/src/main/java/com/vaadin/router/HasUrlParameter.java, line 89 at r2 (raw file):

String parameter = urlParameters.get(0);

Quoted 11 lines of code…

> if (parameterType.isAssignableFrom(String.class)) { > return (T) parameter; > } else if (parameterType.isAssignableFrom(Integer.class)) { > return (T) Integer.valueOf(parameter); > } else if (parameterType.isAssignableFrom(Long.class)) { > return (T) Long.valueOf(parameter); > } else if (parameterType.isAssignableFrom(Boolean.class)) { > return (T) Boolean.valueOf(parameter); > } else { > throw new IllegalArgumentException("Bad type."); > }

This also looks like potentially evolving code.
I would say that even now it should work via number of strategies that are able to handle separate types on their own and shouldn't know about each other.
But for now please extract this as a separate method.
Should be enough for now.

---

flow-server/src/main/java/com/vaadin/router/HasUrlParameter.java, line 91 at r2 (raw file):

throw new IllegalArgumentException("Bad type.");

Not descriptive enough.

---

flow-server/src/main/java/com/vaadin/router/Router.java, line 199 at r2 (raw file):

Boolean

@link please.

---

flow-server/src/main/java/com/vaadin/router/Router.java, line 200 at r2 (raw file):

String

@link please.

---

flow-server/src/main/java/com/vaadin/router/Router.java, line 210 at r2 (raw file):

parameter

plural please

---

Comments from Reviewable

[caalador]

Review status: 1 of 4 files reviewed at latest revision, 7 unresolved discussions.

---

flow-server/src/main/java/com/vaadin/router/HasUrlParameter.java, line 77 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

if (!parameterType.isAssignableFrom(String.class)) {
throw new UnsupportedOperationException(
"Wildcard parameter can only be for String type by default. Implement deserializeUrlParameters for class "
+ this.getClass().getName());
}

This code may be is going to be evolved. So please extract this into a separate method.

Done.

---

flow-server/src/main/java/com/vaadin/router/HasUrlParameter.java, line 89 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

String parameter = urlParameters.get(0);
if (parameterType.isAssignableFrom(String.class)) {
return (T) parameter;
} else if (parameterType.isAssignableFrom(Integer.class)) {
return (T) Integer.valueOf(parameter);
} else if (parameterType.isAssignableFrom(Long.class)) {
return (T) Long.valueOf(parameter);
} else if (parameterType.isAssignableFrom(Boolean.class)) {
return (T) Boolean.valueOf(parameter);
} else {
throw new IllegalArgumentException("Bad type.");
}

This also looks like potentially evolving code.
I would say that even now it should work via number of strategies that are able to handle separate types on their own and shouldn't know about each other.
But for now please extract this as a separate method.
Should be enough for now.

Done.

---

flow-server/src/main/java/com/vaadin/router/HasUrlParameter.java, line 91 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

throw new IllegalArgumentException("Bad type.");

Not descriptive enough.

Done.

---

flow-server/src/main/java/com/vaadin/router/Router.java, line 199 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

Boolean

@link please.

Using @code as anyone coding this should know what a Boolean and a String is.

---

flow-server/src/main/java/com/vaadin/router/Router.java, line 200 at r2 (raw file):

Using @code as anyone coding this should know what a Boolean and a String is.
Using @code as anyone coding this should know what a Boolean and a String is.

---

flow-server/src/main/java/com/vaadin/router/Router.java, line 210 at r2 (raw file):

Previously, denis-anisimov (Denis) wrote…

parameter

plural please

Done.

---

Comments from Reviewable

[denis-anisimov]

Reviewed 3 of 3 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

---

Comments from Reviewable

[denis-anisimov]

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[denis-anisimov]

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[denis-anisimov]

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable