Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webjars bom. #2715

Merged
merged 5 commits into from
Oct 19, 2017
Merged

Use webjars bom. #2715

merged 5 commits into from
Oct 19, 2017

Conversation

SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Oct 18, 2017

Fix flow-components dependencies in a standalone bom that may be updated independently.


This change is Reviewable

@@ -0,0 +1,374 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make this line start at column 3. rule

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.vaadin</groupId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make this line start at column 3. rule

xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-webjars-bom</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make this line start at column 3. rule

<modelVersion>4.0.0</modelVersion>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-webjars-bom</artifactId>
<packaging>pom</packaging>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make this line start at column 3. rule

<groupId>com.vaadin</groupId>
<artifactId>vaadin-webjars-bom</artifactId>
<packaging>pom</packaging>
<version>1.0-SNAPSHOT</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make this line start at column 3. rule

<artifactId>vaadin-webjars-bom</artifactId>
<packaging>pom</packaging>
<version>1.0-SNAPSHOT</version>
<name>Vaadin Webjars (Bill of Materials)</name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make this line start at column 3. rule

<packaging>pom</packaging>
<version>1.0-SNAPSHOT</version>
<name>Vaadin Webjars (Bill of Materials)</name>
<description>Vaadin Webjars (Bill of Materials)</description>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make this line start at column 3. rule

<name>Vaadin Webjars (Bill of Materials)</name>
<description>Vaadin Webjars (Bill of Materials)</description>

<dependencyManagement>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Make this line start at column 3. rule

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 8 issues

  • MINOR 8 minor

Watch the comments in this conversation to review them.

@denis-anisimov
Copy link
Contributor

Reviewed 1 of 4 files at r1, 27 of 45 files at r2.
Review status: all files reviewed at latest revision, 8 unresolved discussions.


Comments from Reviewable

@SomeoneToIgnore SomeoneToIgnore merged commit bb3f226 into master Oct 19, 2017
@SomeoneToIgnore SomeoneToIgnore deleted the kb/use-webjars-bom branch October 19, 2017 06:16
@SomeoneToIgnore SomeoneToIgnore added this to the 1.0.0.alpha6 milestone Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants