Add Grid#setItemDetailsRenderer

[ahie]

This change is 

[gilberto-torrezan]

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

---

flow-components-parent/flow-components/src/main/java/com/vaadin/ui/grid/Grid.java, line 802 at r1 (raw file):

    public void setItemDetailsRenderer(TemplateRenderer<T> renderer) {
        if (detailsTemplate != null) {
            getElement().getNode().runWhenAttached(

Why do you need to remove the current template only when attached?

---

flow-components-parent/flow-components/src/main/java/com/vaadin/ui/grid/Grid.java, line 813 at r1 (raw file):

        detailsTemplate = newDetailsTemplate;
        getElement().getNode().runWhenAttached(

Same question here, but related to append.

---

Comments from Reviewable

[ahie]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

flow-components-parent/flow-components/src/main/java/com/vaadin/ui/grid/Grid.java, line 802 at r1 (raw file):

Previously, gilberto-torrezan (Gilberto Torrezan) wrote…

Why do you need to remove the current template only when attached?

I guess it is not really needed. Just wanted to reduce the possibility of undefined behavior.

---

Comments from Reviewable

[ahie]

Review status: 1 of 4 files reviewed at latest revision, 2 unresolved discussions.

---

flow-components-parent/flow-components/src/main/java/com/vaadin/ui/grid/Grid.java, line 813 at r1 (raw file):

Previously, gilberto-torrezan (Gilberto Torrezan) wrote…

Same question here, but related to append.

Removed both runWhenAttached.

---

Comments from Reviewable

[gilberto-torrezan]

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[gilberto-torrezan]

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

---

Comments from Reviewable

[vaadin-bot]

SonarQube analysis reported 2 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

1. Grid.java#L334: Define a constant instead of duplicating this literal "template" 3 times.
2. Grid.java#L336: Define a constant instead of duplicating this literal "innerHTML" 3 times.