-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for freezing grid columns #2784
Conversation
…2708-grid-freezing-columns
Reviewed 3 of 3 files at r1. flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 221 at r1 (raw file):
This can break if the internals of the component changes over time. One way of testing this is just to evaluate the Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 221 at r1 (raw file): Previously, gilberto-torrezan (Gilberto Torrezan) wrote…
Thing is, it is not actually applied to the Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 221 at r1 (raw file): Previously, ahie (Aleksi Hietanen) wrote…
At least selenium didn't correctly pick it up from the column element. Comments from Reviewable |
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 221 at r1 (raw file): Previously, ahie (Aleksi Hietanen) wrote…
Improved the test. Comments from Reviewable |
Reviewed 3 of 3 files at r2. Comments from Reviewable |
This change is