Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for freezing grid columns #2784

Merged
merged 10 commits into from
Oct 27, 2017
Merged

Add API for freezing grid columns #2784

merged 10 commits into from
Oct 27, 2017

Conversation

ahie
Copy link
Contributor

@ahie ahie commented Oct 26, 2017

This change is Reviewable

@gilberto-torrezan
Copy link
Contributor

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 221 at r1 (raw file):

                grid.getAttribute("columnReorderingAllowed"));

        String idColumnFrozenStatusScript = "return arguments[0].shadowRoot.querySelectorAll('th')[0].getAttribute('frozen')";

This can break if the internals of the component changes over time. One way of testing this is just to evaluate the frozen property of the vaadin-grid-column element, outside the shadow root. That's public API, so it shouldn't change unless a major version is released.


Comments from Reviewable

@ahie
Copy link
Contributor Author

ahie commented Oct 27, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 221 at r1 (raw file):

Previously, gilberto-torrezan (Gilberto Torrezan) wrote…

This can break if the internals of the component changes over time. One way of testing this is just to evaluate the frozen property of the vaadin-grid-column element, outside the shadow root. That's public API, so it shouldn't change unless a major version is released.

Thing is, it is not actually applied to the vaadin-grid-column element.


Comments from Reviewable

@ahie
Copy link
Contributor Author

ahie commented Oct 27, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 221 at r1 (raw file):

Previously, ahie (Aleksi Hietanen) wrote…

Thing is, it is not actually applied to the vaadin-grid-column element.

At least selenium didn't correctly pick it up from the column element.


Comments from Reviewable

@ahie
Copy link
Contributor Author

ahie commented Oct 27, 2017

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


flow-components-parent/demo-flow-components/src/test/java/com/vaadin/flow/demo/views/GridViewIT.java, line 221 at r1 (raw file):

Previously, ahie (Aleksi Hietanen) wrote…

At least selenium didn't correctly pick it up from the column element.

Improved the test.


Comments from Reviewable

@gilberto-torrezan
Copy link
Contributor

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@ahie ahie merged commit 34a9d84 into master Oct 27, 2017
@ahie ahie deleted the 2708-grid-freezing-columns branch October 27, 2017 11:47
@SomeoneToIgnore SomeoneToIgnore added this to the 1.0.0.alpha8 milestone Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants