Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the documentation structure #3305

Merged
merged 2 commits into from
Jan 16, 2018
Merged

Refactor the documentation structure #3305

merged 2 commits into from
Jan 16, 2018

Conversation

pleku
Copy link
Contributor

@pleku pleku commented Jan 12, 2018

Fixes #1698

Moves all files around to make sure content is aligned into preferable reading order.
Also adds a very shallow introduction / architecture page.


This change is Reviewable

@pleku
Copy link
Contributor Author

pleku commented Jan 12, 2018

Review status: 0 of 92 files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):
Still need to revise and fix the page ordering and headers for all sections (used in vcom menu).


Comments from Reviewable

@denis-anisimov
Copy link
Contributor

Reviewed 159 of 159 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


flow-documentation/introduction/introduction-overview.asciidoc, line 41 at r1 (raw file):

// CODE SNIPPET //

Is it supposed to be filled later on?
Is it OK to keep it as is for now?


Comments from Reviewable

Fixes #1698

Moves all files around to make sure content is aligned into preferable reading order.
Also adds a very shallow introduction / architecture page.
@pleku
Copy link
Contributor Author

pleku commented Jan 15, 2018

Review status: 70 of 93 files reviewed at latest revision, 2 unresolved discussions.


flow-documentation/introduction/introduction-overview.asciidoc, line 41 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…

// CODE SNIPPET //

Is it supposed to be filled later on?
Is it OK to keep it as is for now?

Yeah I have separate list of things to fix in the documentation content, this one is there and I just with to get the structure change now in so that I don't have to keep on fixing merge conflicts...


Comments from Reviewable

@pleku
Copy link
Contributor Author

pleku commented Jan 15, 2018

Review status: 70 of 93 files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, pleku (Pekka Hyvönen) wrote…

Still need to revise and fix the page ordering and headers for all sections (used in vcom menu).

Done


Comments from Reviewable

@denis-anisimov
Copy link
Contributor

Reviewed 13 of 159 files at r1, 22 of 26 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ZheSun88 ZheSun88 merged commit 2c5f013 into master Jan 16, 2018
@ZheSun88 ZheSun88 deleted the refactor_docs branch January 16, 2018 06:20
@ZheSun88 ZheSun88 added this to the 1.0.0.alpha18 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants